Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use arbitrary make goals in Makefile header, rendered as buttons #142

Open
matentzn opened this issue Feb 2, 2024 · 3 comments

Comments

@matentzn
Copy link

matentzn commented Feb 2, 2024

Right now we can only declare PHONY goals in the root Makefile as buttons. It would be nice if we could

a) have non-phony goals as buttons
b) have goals in extended (included) makefiles referenced

This will help to create custom workflows for ontologies.

@jamesaoverton
Copy link
Member

  1. This is already part of DROID. In the Workflow section, if you just specify a file inside backticks, DROID will run Make to ensure the file is built and up-to-date. In other words you just write 'foo.txt' not 'make foo.txt' (always in backticks). Files are rendered as links, not buttons. Please try it to confirm.

  2. DROID does not yet follow Make's 'import' declarations, but I guess it should.

@jamesaoverton
Copy link
Member

New issue covering 2: #143

If 1 is already covered please close this issue. Otherwise let me know what behaviour you want.

@matentzn
Copy link
Author

matentzn commented Feb 3, 2024

This is already part of DROID. In the Workflow section, if you just specify a file inside backticks, DROID will run Make to ensure the file is built and up-to-date. In other words you just write 'foo.txt' not 'make foo.txt' (always in backticks)

@anitacaron can you check that (1) you dont need to add the make and (2) that when you use backticks without the make (foo.txt), DROID does not open another tab?

Files are rendered as links, not buttons.

For now this is ok of course. I was mainly concerned about the fact that when make foo.txt was used, a new window was opened, instead of behaving analogously to when you click on a button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants