Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location of KBs directory is hard coded in java files #39

Open
arademaker opened this issue Jun 21, 2019 · 8 comments
Open

location of KBs directory is hard coded in java files #39

arademaker opened this issue Jun 21, 2019 · 8 comments

Comments

@arademaker
Copy link
Contributor

arademaker commented Jun 21, 2019

src/java/com/articulate/sigma/KBmanager.java
85           String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
97           String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
125          String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
154              String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
185              String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
223              File kbDir = new File(baseDir, "KBs");
593          initializeOnce(base + File.separator + "KBs");

test/unit/java/com/articulate/sigma/SigmaTestBase.java
13       protected static final String KB_PATH = (new File(SIGMA_HOME, "KBs")).getAbsolutePath();

src/java/com/articulate/sigma/nlg/NLGUtils.java
16       //private static final String KB_PATH = (new File(SIGMA_HOME, "KBs")).getAbsolutePath() + File.separator + "WordNetMappings";
37           String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
48           String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
71               String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";
101              String kbDir = System.getenv("SIGMA_HOME") + File.separator + "KBs";

src/java/com/articulate/sigma/wordNet/WordNet.java
1831                     WordNet.baseDir = System.getenv("SIGMA_HOME") + File.separator + "KBs" + File.separator + "WordNetMappings";

test/unit/java/com/articulate/sigma/nlg/SigmaMockTestBase.java
23       private static final String KB_PATH = (new File(SIGMA_HOME, "KBs")).getAbsolutePath();
@arademaker
Copy link
Contributor Author

all these cases should lookup the value of the parameter kbDir in the config.xml file.

@apease
Copy link
Contributor

apease commented Jun 21, 2019

it's all relative to SIGMA_HOME, which is what is intended

@apease
Copy link
Contributor

apease commented Jun 21, 2019

you're right, that would be better

@arademaker
Copy link
Contributor Author

My workaround was to create a symlink, but since I don't know how to make reference to the config.xml parameter in your java code, I created this issue. I believe that should be something easy to fix.

@arademaker
Copy link
Contributor Author

related to it, we have two parameters in the config.xml that point to an invalid path ~/workspace/sigma/sigma: systemsDir and tptpHomeDir

These parameters are used? What should be the correct value for them?

@apease
Copy link
Contributor

apease commented Jun 21, 2019

kbDir is set during initialization of KBmanager so I've changed all but SigmaTestBase and SigmaMockTestBase

@apease
Copy link
Contributor

apease commented Jun 21, 2019

reverting, this breaks the startup sequence

@apease
Copy link
Contributor

apease commented Jun 21, 2019

fixed this in NLGutils and WordNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants