Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix obsolete classes display #352

Closed
syphax-bouazzouni opened this issue Oct 10, 2023 · 2 comments · Fixed by ontoportal-lirmm/ontologies_api_ruby_client#13
Closed

fix obsolete classes display #352

syphax-bouazzouni opened this issue Oct 10, 2023 · 2 comments · Fixed by ontoportal-lirmm/ontologies_api_ruby_client#13
Assignees

Comments

@syphax-bouazzouni
Copy link
Collaborator

In AgroPortal, for the ontology SeaDataNet Device Thesaurus, all the terms are displayed as obsolete (in grey) even if the backend returned the obsolete property as false.

Image

Example

The class "SeaDataNet sample collector categories", we see in the backed (https://data.agroportal.lirmm.fr/ontologies/SDNDEV/classes/http%3A%2F%2Fvocab.nerc.ac.uk%2Fcollection%2FL21%2Fcurrent%2FICAT01%2F?display=all) that the obsolete property is "false"

Image

But in the UI, it is shown as "true"

Image

@syphax-bouazzouni
Copy link
Collaborator Author

syphax-bouazzouni commented Oct 10, 2023

I suppose that the issue is that "false" is read in the UI as a String and not parsed to a boolean when the test is done to say if obsolete or not. ("false" is true in a condition)

@SirineMhedhbi Could you fix this issue and do your PR against the master branch?

@syphax-bouazzouni
Copy link
Collaborator Author

syphax-bouazzouni commented Oct 17, 2023

OK, so this was a more complex issue than we thought.

There are two issues:

But even with this fix the concept remained in grey, because of the second issue described below in the screenshot

image image

to make this works two fixes were made in the backend ontoportal-lirmm/ontologies_api#50 and ontoportal-lirmm/ontologies_linked_data#101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants