Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cagtegories page not working in StagePortal #866

Closed
syphax-bouazzouni opened this issue Nov 22, 2024 · 8 comments
Closed

cagtegories page not working in StagePortal #866

syphax-bouazzouni opened this issue Nov 22, 2024 · 8 comments

Comments

@syphax-bouazzouni
Copy link
Collaborator

https://stageportal.lirmm.fr/categories

@Bilelkihal
Copy link
Collaborator

fixed here: #858 and deployed to stage,
It was about some categories that are removed but still used as parent category for certain other categories.

@syphax-bouazzouni
Copy link
Collaborator Author

Is this not a bigger issue where, when we delete a category, we also need to delete its references as parent of child?

@Bilelkihal
Copy link
Collaborator

Bilelkihal commented Nov 25, 2024

No need for this, since it's an admin only feature (and not used frequently)

@syphax-bouazzouni
Copy link
Collaborator Author

It was done for the relation categories <->ontologies, here: https://github.com/ontoportal-lirmm/bioportal_web_ui/pull/254/files#diff-1677c16da6a7f15bfb619547bcab5ddce1eb422fe4b8b96a971bb2cdafc47c99R27, so it need to be done also for the relation categories <->categories

@Bilelkihal
Copy link
Collaborator

Currently, when a category is associated with some ontologies, then we disable the delete button in the admin page:
image

And it's easy here to deal with if you want to delete the category anyway, you click on edit, you empty the ontologies list and then you delete.

But with parentCategories, you need to remove the category everywhere where it appears as a parentCategory and you can't have an idea who are those categories who are mentioning this category.

@syphax-bouazzouni
Copy link
Collaborator Author

@jonquet what is your opinion on this ?

@jonquet
Copy link

jonquet commented Nov 27, 2024

But with parentCategories, you need to remove the category everywhere where it appears as a parentCategory and you can't have an idea who are those categories who are mentioning this category.
=>Unless you use the UI Category page.

That sounds reasonable that to delete a category one verify that it's not referenced as a parent category somewhere.

@Bilelkihal
Copy link
Collaborator

But with parentCategories, you need to remove the category everywhere where it appears as a parentCategory and you can't have an idea who are those categories who are mentioning this category.
=>Unless you use the UI Category page.

That sounds reasonable that to delete a category one verify that it's not referenced as a parent category somewhere.

Done here: #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants