Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Upstream Maili SpecId Retriever #971

Closed
refcell opened this issue Jan 28, 2025 · 1 comment
Closed

Use Upstream Maili SpecId Retriever #971

refcell opened this issue Jan 28, 2025 · 1 comment
Labels
A-executor Area: kona-executor crate K-chore Kind: chore M-good-first-issue Meta: Good for newcomers

Comments

@refcell
Copy link
Collaborator

refcell commented Jan 28, 2025 •
edited
Loading

Description

op-rs/maili#142 in Maili, introduces a spec_id(timestamp) method on the RollupConfig within the maili-genesis crate.
https://github.com/op-rs/kona/blob/main/crates/executor/src/executor/env.rs#L22-L45 should be removed to use this spec_id method
directly on the RollupConfig instead.

Note

The spec_id(timestamp) method is only available when the revm feature flag is enabled on the maili-genesis crate.
@refcell refcell added K-chore Kind: chore A-executor Area: kona-executor crate M-good-first-issue Meta: Good for newcomers labels Jan 28, 2025
@refcell refcell mentioned this issue Jan 30, 2025
Merged
@clabby
Copy link
Collaborator

clabby commented Feb 5, 2025

This was closed by #979 - thanks!

@clabby clabby closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-executor Area: kona-executor crate K-chore Kind: chore M-good-first-issue Meta: Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clabby @refcell