Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatQnA benchmark tests(#995) #998

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

ChatQnA benchmark tests(#995) #998

wants to merge 37 commits into from

Conversation

Zhenzhong1
Copy link
Collaborator

@Zhenzhong1 Zhenzhong1 commented Oct 21, 2024

Description

  • Refactor ChatQnA benchmark

Issues

N/A

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Oct 21, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@chensuyue chensuyue added the WIP label Oct 21, 2024
@jfding
Copy link

jfding commented Oct 22, 2024

Please hold on such changes that going to add helm charts to GenExamples apps, for we are still on the way to nail down bunch of rules of how to prepare helm charts for apps and comps.

@hshen14
Copy link
Contributor

hshen14 commented Oct 22, 2024

Please hold on such changes that going to add helm charts to GenExamples apps, for we are still on the way to nail down bunch of rules of how to prepare helm charts for apps and comps.

@ftian1 will be presenting the status and the proposal. Yes, let's move forward after things are synced.

@Zhenzhong1 Zhenzhong1 marked this pull request as draft October 23, 2024 00:59
@Zhenzhong1 Zhenzhong1 changed the title benchmark helmcharts (#995) ChatQnA benchmark tests(#995) Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants