Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image standards #59

Closed
RustoMCSpit opened this issue Dec 15, 2024 · 2 comments
Closed

image standards #59

RustoMCSpit opened this issue Dec 15, 2024 · 2 comments

Comments

@RustoMCSpit
Copy link
Contributor

looking at the images, theyre all at different ratios, resolutions, etc.

having a standard would enable things like this
studiorack/studiorack-site#20

we can have unstandarised images when you click into the plugin but not for its cover image like below

17342788182538193197278625054950

related #45

@kmturley
Copy link
Member

Looking at other plugin websites, they have the same issue:
https://www.kvraudio.com/plugins/the-newest-plugins

The issue is that every plugin has different ratio of width vs height. Some are square, some horizontal some vertical.

With StudioRack I made the same decision to allow any ratio, as cropping parts off images doesn't make sense and looks strange.

I get around this by resizing thumbnail images on the list to the same width, which shows a sneak peak of each plugin:
https://studiorack.github.io/studiorack-site/instruments

Then on the plugin detail page, images are shown full size and centered:

This way there is more consistency on the list page, and the detail page shows the full plugin UI no matter the dimensions and ratio.

If we add custom thumbnails for the list page, it requires resizing and cropping another image for every plugin added.
This is something which could be done automatically but a server-side script, rather than manually.

I prefer to keep the plugin spec simpler, and lower effort to add plugins for now. Rather than adding more work.

By the way, when StudioRack list page loads, it only loads the images in view. So even if they are high resolution, they don't all get loaded at once. They are lazy-loaded as you scroll.

So in summary, I don't agree with:

  • Multiple images for list/detail view
  • Forcing images to be the same resolution
  • Forcing images to be the same width

But I do agree there should be some standards around images. I have already updated the Registry specification to say:

Image preview url (https). Allows users to preview the user interface of the plugin before downloading. Technically this could be any image file format, but we recommend .jpg as it is compressed and widely supported. Tips: Crop to plugin UI edges, avoid backgrounds, borders and/or drop-shadows. Can be any shape/dimension (square, rectangle) but limit size to around 1000px to optimize loading times for large lists of plugins.
https://docs.google.com/document/d/14ljz4XNXr02xgdDHksPMl2vaM-Jn-YnJ_VzI1WsvSKQ/edit?tab=t.0#heading=h.ug9e3ljuigte

So I think this request is already covered in the specification document.

And the Registry plugin validation recommends to use jpg if another format is used.
https://github.com/open-audio-stack/open-audio-stack-core/blob/main/src/helpers/package.ts#L60

Later it could be extended to check image minimum size.

@RustoMCSpit
Copy link
Contributor Author

RustoMCSpit commented Dec 17, 2024

If we add custom thumbnails for the list page, it requires resizing and cropping another image for every plugin added.
This is something which could be done automatically but a server-side script, rather than manually.

it could and should be done by the plugin uploader. this is just telling devs to give us a standardised image. this isnt labor we should have to do for them. yes, that slightly raises the bar of difficulty in uploading but i find it worth it. i understand you want to keep the barrier of entry as low as possible but it looks like a mess lol.

another strategy is to do what i did for this plugin and instead make an image out of text rather than the gui itself, it's less informative however. there is a logo included though

image

I prefer to keep the plugin spec simpler, and lower effort to add plugins for now. Rather than adding more work.

is .jxl allowed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants