Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Placement snippets and templates #29

Closed
TomerFi opened this issue Dec 9, 2022 · 4 comments · Fixed by #63, #69 or #70
Closed

Update Placement snippets and templates #29

TomerFi opened this issue Dec 9, 2022 · 4 comments · Fixed by #63, #69 or #70
Assignees

Comments

@TomerFi
Copy link
Member

TomerFi commented Dec 9, 2022

Placement CRD can be found here.

Resource docs can be found here.

Snippets are saved in our snippets directory.

Templates are saved in our templates directory.

VSCode Snippet Guide.
VSCode Using Snippets.

Related issue: #21

Templates are a part of our ocmNewProject command, no vscode docs available.
We have multiple templates, each template as its own Placement manifest.

@ilan-pinto
Copy link
Member

why reopened

@TomerFi
Copy link
Member Author

TomerFi commented May 4, 2023

We updated only the templates. Not the snippet.

@TomerFi
Copy link
Member Author

TomerFi commented May 4, 2023

@ilan-pinto we're confusing #26 (channel) and this one (placement).
The recent PR updates the placement templates, but not the snippet:
https://github.com/open-cluster-management-io/ocm-vscode-extension/blob/main/snippets/placement.json

image

We also need to decide if we want to allow users to use old manifests. Meaning, should we add another snippet:

{
	"placement-v1alpha1": {
            ...
	},
	"placement-v1beta1": {
            ...
	}
}

Or replace the current one:

{
	"placement": {
            ...
	}
}

As you can see with the current object key, the original intention was to keep multiple versions.

ilan-pinto added a commit to ilan-pinto/ocm-vscode-extension-on-ocm that referenced this issue May 4, 2023
@TomerFi TomerFi linked a pull request May 4, 2023 that will close this issue
@TomerFi
Copy link
Member Author

TomerFi commented May 4, 2023

fixed in #69

@TomerFi TomerFi closed this as completed May 4, 2023
@TomerFi TomerFi linked a pull request May 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment