Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize name in NewArtifactFor #298

Open
9 tasks
frewilhelm opened this issue Oct 21, 2024 · 0 comments
Open
9 tasks

Sanitize name in NewArtifactFor #298

frewilhelm opened this issue Oct 21, 2024 · 0 comments
Labels

Comments

@frewilhelm
Copy link

Description

Currently, NewArtifactFor() creates an artifact-name by pasting the kind, namespace, and name (derived from the parent-resource). However, there are some restrictions towards the naming of k8s resources, which could possibly break the code (e.g. length, see https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names).

Accordingly, we should discuss if we want to sanitize the input and how to create the artifacts name.

Done Criteria

  • ...
  • Code has been reviewed by other team members
  • Internal technical Documentation created/updated
  • New / changed code is documented
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Successful demonstration in Review
@frewilhelm frewilhelm added the kind/task General Task label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 ToDo
Development

No branches or pull requests

1 participant