Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git commit sha as version sent to Scrapyd #802

Open
jpmckinney opened this issue Sep 23, 2021 · 1 comment
Open

Use git commit sha as version sent to Scrapyd #802

jpmckinney opened this issue Sep 23, 2021 · 1 comment
Labels
blocked We can't do this yet framework Relating to other common functionality

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Sep 23, 2021 •
edited
Loading

See https://github.com/scrapy/scrapyd-client#versioning

This means (if we have a use case) that we can send to Kingfisher Process the code version, to know which version of a spider was run (for troubleshooting) (was #411). If this isn't accessible as the SCRAPY_EGG_VERSION environment variable, then we might be able to determine the latest egg.
@jpmckinney jpmckinney added the framework Relating to other common functionality label Sep 23, 2021
@yolile yolile mentioned this issue Sep 23, 2021
Closed
@jpmckinney jpmckinney added the blocked We can't do this yet label Sep 24, 2021
@yolile
Copy link
Member

yolile commented Oct 26, 2021

Blocked until scrapy/scrapyd#212 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked We can't do this yet framework Relating to other common functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scrapy config: use GIT revision as scrapyd version open-contracting/kingfisher-collect
2 participants
@jpmckinney @yolile