Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving codelist and openCodelist to correct subschema #1631

Open
jpmckinney opened this issue Jul 17, 2023 · 1 comment
Open

Consider moving codelist and openCodelist to correct subschema #1631

jpmckinney opened this issue Jul 17, 2023 · 1 comment
Labels
Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.)

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Jul 17, 2023

Presently, codelist and openCodelist are at the OCDS "field" level, e.g. properties/tag.

However, tag is an array of codes. In JSON Schema, it would make more sense to add these fields at properties/tag/items (where enum is already, in OCDS 1.1).

By not having the validation properties at the correct level, lib-cove-ocds (and any other JSON Schema validator) needs to implement workarounds.

That said, the effort to update tools might be too great. One option would be to start having tools pre-process schema and move these properties to the correct location. Once all tools have done this, it will be easier to change the schema.

Edit: Since March 2023, lib-cove checks for these at the array item level: OpenDataServices/lib-cove@8e97601

@jpmckinney jpmckinney added the Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) label Jul 17, 2023
@duncandewhurst
Copy link
Contributor

Noting that OCDS Kit's mapping sheet command would need updating as it expects codelist to be at field level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants