Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3] Resource warnings during yarn build #126

Open
2 of 5 tasks
willroberts opened this issue Oct 13, 2022 · 1 comment
Open
2 of 5 tasks

[P3] Resource warnings during yarn build #126

willroberts opened this issue Oct 13, 2022 · 1 comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed

Comments

@willroberts
Copy link
Collaborator

Summary

[21:01:10] Starting 'rsx:packages'...
 [GP] Packaging resources for STANDARD files...
 [GP] [WARN] app/view/layers/arena/RunLayer.js -> matched RSX search but no resource could be found for: RSX[`key_blade_${bladeNumber}`
 [GP] [WARN] app/view/layers/arena/RunLayer.js -> matched RSX search but no resource could be found for: RSX[`key_blade_outline_glow_${bladeNumber}`
 [GP] [WARN] app/view/layers/booster/BoosterPackOpeningLayer.js -> matched RSX search but no resource could be found for: RSX[`sfx_loot_crate_card_reward_reveal_${index}`
 [GP] [WARN] app/view/layers/postgame/LadderProgressLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${this._currentShownDivisionKey}`
 [GP] [WARN] app/view/layers/postgame/LadderProgressLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${SDK.RankFactory.rankedDivisionAssetNameForRank(rank)}`
 [GP] [WARN] app/view/layers/postgame/LadderProgressLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${this._currentShownDivisionKey}`
 [GP] [WARN] app/view/layers/postgame/LadderProgressLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${this._currentShownDivisionKey}_glow_outline`
 [GP] [WARN] app/view/layers/game/TileLayer.js -> matched RSX search but no resource could be found for: RSX[`${tilePrefix}0${mergedTilePartId}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_glow_${friendOrEnemy}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_background_${result}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_middleground_${result}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_blurred_${friendOrEnemy}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_glow_${friendOrEnemy}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_background_${result}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_middleground_${result}`
 [GP] [WARN] app/view/layers/postgame/VictoryLayer.js -> matched RSX search but no resource could be found for: RSX[`scene_diamonds_blurred_${friendOrEnemy}`
 [GP] [WARN] app/view/layers/pregame/MatchmakingLayer.js -> matched RSX search but no resource could be found for: RSX[`f${factionId}_runes`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(this._previousTopRank)}`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(this._previousTopRank)}_glow_outline`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(GamesManager.getInstance().getCurrentRank())}`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(this._previousTopRank)}`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(this._previousTopRank)}_glow_outline`
 [GP] [WARN] app/view/layers/season/EndOfSeasonLayer.js -> matched RSX search but no resource could be found for: RSX[`season_rank_${RankFactory.rankedDivisionAssetNameForRank(GamesManager.getInstance().getCurrentRank())}`
 [GP] [WARN] app/view/layers/rift/UpgradeCardLayer.js -> matched RSX search but no resource could be found for: RSX[`sfx_loot_crate_card_reward_reveal_${index}`
 [GP] [WARN] app/ui/views2/shop/shop_product_view.js -> matched RSX search but no resource could be found for: RSX[this.model.get("icon_image_resource_name")
 [GP] [WARN] app/ui/views2/shop/confirm_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.cover_image_resource_name
 [GP] [WARN] app/ui/views2/shop/confirm_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.icon_image_resource_name
 [GP] [WARN] app/ui/views2/shop/premium_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.cover_image_resource_name
 [GP] [WARN] app/ui/views2/shop/premium_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.icon_image_resource_name
 [GP] [WARN] app/view/nodes/cards/TooltipNode.js -> matched RSX search but no resource could be found for: RSX[`tooltip_${this._carrotDirection}`
 [GP] [WARN] app/view/nodes/cards/InstructionNode.js -> matched RSX search but no resource could be found for: RSX[`tooltip_${this._carrotDirection}`
 [GP] [WARN] app/ui/views/helpers.js -> matched RSX search but no resource could be found for: RSX[resourceName
 [GP] Resources packed for STANDARD files!
 [GP] Packaging resources for SPECIAL files...
 [GP] [WARN] app/view/layers/game/BattleMap.js -> matched RSX search but no resource could be found for: RSX[`ptcl_cloud_00${cloudIndex}`
 [GP] Resources packed for SPECIAL files!
 [GP] Packaging resources for CARD FACTORY...
 [GP] [WARN] Cards.Spell.FollowupTeleportNearMyGeneral -> not found in cards lookup at part:  FollowupTeleportNearMyGeneral
 [GP] Resources packed for CARD FACTORY!
 [GP] Wrapping packages...
 [GP] [WARN] card ForgeArtifact -> has no inspect package!
 [GP] [WARN] card ForgeArtifact -> has no game package!
 [GP] [WARN] card FestiveSpirit -> has no inspect package!
 [GP] [WARN] card SpellDuplicator -> has no inspect package!
 [GP] FORCE UPLOAD ALL RESOURCES
 [GP] Packages wrapped!

Impacted services

  • The frontend app
  • The game servers
  • Game builds or automation scripts
  • Tests or Github Actions
  • Infrastructure (Terraform)

Steps to reproduce

  1. yarn build
@willroberts willroberts added bug Something isn't working help wanted Extra attention is needed P3 frontend Related to app / game client code labels Oct 13, 2022
@willroberts willroberts changed the title [APP] Resource warnings during yarn build [P3] Resource warnings during yarn build Oct 13, 2022
@willroberts willroberts removed the P3 label Oct 13, 2022
@willroberts
Copy link
Collaborator Author

Most of these were fixed in #215.

Remaining issues (with explanations from that PR):

[GP] [WARN] app/view/layers/game/TileLayer.js -> matched RSX search but no resource could be found for: RSX[`${tilePrefix}0${mergedTilePartId}`

"This happens due to too short string ("0", it is just too generic and may match most of the resources)."

[GP] [WARN] app/ui/views2/shop/shop_product_view.js -> matched RSX search but no resource could be found for: RSX[this.model.get('icon_image_resource_name')
[GP] [WARN] app/ui/views2/shop/confirm_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.cover_image_resource_name
[GP] [WARN] app/ui/views2/shop/confirm_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.icon_image_resource_name
[GP] [WARN] app/ui/views/helpers.js -> matched RSX search but no resource could be found for: RSX[resourceName
[GP] [WARN] app/ui/views2/shop/premium_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.cover_image_resource_name
[GP] [WARN] app/ui/views2/shop/premium_purchase_dialog.js -> matched RSX search but no resource could be found for: RSX[this.productData.icon_image_resource_name

"They happen due to runtime property forming therefore there is no way to get them in build time. I guess they were there even before and were considered as acceptable. To say for sure need to get where and how that package.json is used."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to app / game client code help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant