Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds preliminary support for playing on mobile web #222

Merged
merged 8 commits into from
Oct 29, 2022

Conversation

willroberts
Copy link
Collaborator

@willroberts willroberts commented Oct 29, 2022

Summary

This has already been deployed to https://staging.duelyst.org as a one-off. There are still a few remaining issues (see #220 and #221), but this makes things playable!

Closes #109.

App changes (app/, etc.):

  • Changes viewport width from 800 to device-width to enable automatic scaling
  • Reduces initial viewport scale from 1.0 to 0.1 (the minimum) which allows devices to scale up to their resolution
  • Adds support for hiding the status/navigation bar in Google Chrome "Add to Home Screen" apps
  • Updates docs

Testing

Have you have tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

@willroberts willroberts merged commit cb1a643 into open-duelyst:main Oct 29, 2022
@willroberts willroberts deleted the mobile branch October 29, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P0] Improve mobile support
1 participant