Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Computer's Mac address should not be hardcoded #1

Open
thomasfla opened this issue Jul 28, 2019 · 2 comments
Open

[SDK] Computer's Mac address should not be hardcoded #1

thomasfla opened this issue Jul 28, 2019 · 2 comments

Comments

@thomasfla
Copy link
Member

https://github.com/solo-bl/master-board/blob/b9e5ec4361b382b84c0e68902e9fa9af10b36f29/software/scripts/src/main.cpp#L13

We should instead get the host mac address from a system call given the interface name.

@thomasfla thomasfla changed the title Computer's Mac address should not be hardcoded [SDK] Computer's Mac address should not be hardcoded Sep 16, 2019
@paLeziart
Copy link
Collaborator

@thomasfla Is is still required or can we close the issue? The test bench works without changing the Mac address so something may have been modified in the code and the address is not required anymore.

@thomasfla
Copy link
Member Author

The master board is configured to accept packets from any MAC sources at the moment. But MAC standard still impose us to provide a source address. It's a bit dirty and make the network analysis difficult to keep an hard coded value here.

Also, later, it could be useful to filter incoming packets in the Master Board when using WiFi.

jviereck pushed a commit that referenced this issue Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants