Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change class name UclaMiniscopeV4CameraFrame -> UclaMiniscopeV4CameraDataFrame #379

Open
cjsha opened this issue Dec 6, 2024 · 1 comment · May be fixed by #380
Open

Change class name UclaMiniscopeV4CameraFrame -> UclaMiniscopeV4CameraDataFrame #379

cjsha opened this issue Dec 6, 2024 · 1 comment · May be fixed by #380
Assignees
@cjsha
Labels
proposal Request for a new feature

Comments

@cjsha
Copy link
Member

cjsha commented Dec 6, 2024

This name change suggestion is to adhere to our naming convention. The operator is UclaMiniscopeV4CameraData so its corresponding frame should be appended by "Frame": UclaMiniscopeV4CameraDataFrame.
@cjsha cjsha self-assigned this Dec 6, 2024
@cjsha cjsha linked a pull request Dec 6, 2024 that will close this issue
Open
@aacuevas aacuevas added the proposal Request for a new feature label Dec 9, 2024
@aacuevas
Copy link
Collaborator

aacuevas commented Dec 9, 2024

There apparently was a discussion about why this particular operator had a different name.
If this is the case, we should at least document in the code the rationale for not adhering to the convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjsha cjsha

Labels
proposal Request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename UclaMiniscopeV4CameraFrame open-ephys/bonsai-onix1
2 participants
@aacuevas @cjsha