Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 support for the blob sync #1449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djosephsen
Copy link
Contributor

This PR

Intent of this pr is to add S3 bucket support to the existing "blob" sync.

Related Issues

fixes #1376

Notes

Marking as a draft for now until I can find my aws creds and live-test it.

Follow-up Tasks

integration testing is yet to be performed

How to test

unit tests provided

@djosephsen djosephsen requested a review from a team as a code owner November 12, 2024 23:30
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 05888fc
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6733e526d5a3bf0007b385e7

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try and test this E2E as soon as possible. In the meantime, could you please update the documentation to include s3 as a source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add S3-compatiblty sync source
2 participants