-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] [Angular] Not removing enable when switch to disabled #1116
Comments
Hey @lukas-reining, would you mind looking at this when you have a moment? |
Hey, @UnleashSpirit, thanks for reporting this! |
Hey @UnleashSpirit, I had a look into the issue and I have trouble replicating it. I added a simple flag change test using exactly the same HTML as the example to the Angular Test App that I used for showing the features of the Angular SDK. I also created an Angular 16 branch there, this does not have the issue you described too. Can you please also test this code on your side? https://github.com/open-feature/angular-test-app/tree/example/test-angular-16 If my demo App is working for you I would be happy if you could supply me with some more code that has the issue. Thank you! |
Hi, thanks for the quick response. |
Okay, would be happy about feedback once you find it out or have additional information!
Thanks @UnleashSpirit ! :) |
Hi, I test it from scratch with a Angular@16 apps and everythings works like a charm So this is our application, but now I need to understand why. As it's a huge application, it will take time (especially since this openfeature is a poc so no priority) Sorry for the fake bug :( |
Okay, if there is a part of the App that you can share where you use it, feel free to provide me with the snippet to see if I can find anything @UnleashSpirit. You can also find me on the CNCF slack if you want. Otherwise feel free to come back if it turns out the SDK has anything todo with your problem, maybe it is a very special case. Will close this then :) |
Observed behavior
Hi, we just testing some Openfeature with our Angular 16+ apps
We test the exemple from here https://openfeature.dev/docs/reference/technologies/client/web/angular#boolean-feature-flag
A simple copy/paste, we also use flagd as provider, everything seems to works (connection, event, etc...)
The problem we have is that when we sitch from "on" to "off" the "on message" does not disapear.
We se the "initializing" then it's replaced by the "enable" but when we disable the feature we got this
Expected Behavior
Only the disabled message to be print
Steps to reproduce
In a basic component use the exemple code in the doc
In the flagd switch from
"defaultVariant": "on"
to"defaultVariant": "off"
and we have the two messages (as shown above)The text was updated successfully, but these errors were encountered: