Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display progress correctly in the presence of masked values #13

Open
gnn opened this issue May 23, 2017 · 0 comments
Open

Display progress correctly in the presence of masked values #13

gnn opened this issue May 23, 2017 · 0 comments
Assignees

Comments

@gnn
Copy link
Collaborator

gnn commented May 23, 2017

Some values are masked representing missing data. These values are not imported at all into the database but when calculating how many values to import they are still taken into account, as this calculation doesn't actually loop over all values but just multiplies dimension lengths. This results in an import that finishes before the progress bar reaches 100%.
As it might take too long to loop over all values just to check whether they are masked or not, this might actually not get fixed at all. I'm still on the fence over this. I also kinda like being able to see (roughly) how many values where masked.

@gnn gnn self-assigned this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant