Clippy fixes and changing refs to Copy #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
237: travis: Enable Windows and MacOS builds r=behnam a=behnam <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237) <!-- Reviewable:end --> 252: Clippy fixes and changing refs to Copy r=CAD97 a=JamesHinshelwood Updated clippy allows from `cfg_attr` to proc-macro style. Fixed #241 + more - Changed a few `impl`s to take `self` instead of `&self`, when they are `Copy` types. `cargo clippy` should run without any warnings now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/252) <!-- Reviewable:end --> Co-authored-by: Behnam Esfahbod <[email protected]> Co-authored-by: JamesHinshelwood <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
252: Clippy fixes and changing refs to Copy r=CAD97 a=JamesHinshelwood Updated clippy allows from `cfg_attr` to proc-macro style. Fixed #241 + more - Changed a few `impl`s to take `self` instead of `&self`, when they are `Copy` types. `cargo clippy` should run without any warnings now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/252) <!-- Reviewable:end --> Co-authored-by: JamesHinshelwood <[email protected]>
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated clippy allows from
cfg_attrto proc-macro style.Fixed #241 + more - Changed a few
impls to takeselfinstead of&self, when they areCopytypes.cargo clippyshould run without any warnings now.This change is