From cb5d483659c20a762e6b8300b96e6f3f8276726d Mon Sep 17 00:00:00 2001 From: johnmdrake1 <32374869+johnmdrake1@users.noreply.github.com> Date: Wed, 24 Jul 2019 00:29:19 -0500 Subject: [PATCH] Add notes to First Steps and Github Issues Pages to Clarify it is OK to Move On (fixes #2554) (#2591) --- pages/vi/vi-first-steps.md | 4 +++- pages/vi/vi-github-issues.md | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pages/vi/vi-first-steps.md b/pages/vi/vi-first-steps.md index e4ed81127..5a2670fc8 100644 --- a/pages/vi/vi-first-steps.md +++ b/pages/vi/vi-first-steps.md @@ -75,13 +75,15 @@ Follow the directions at [Git Repositories](vi-github-and-repositories.md) to ke Follow the tutorial under the [GitHub Issues tab](vi-github-issues.md) to create at least one issue. Post a link in [Gitter](https://gitter.im/open-learning-exchange/chat) whenever you create an issue or when you comment on someone else's issue. You are encouraged to post as many issues as you can for improving the page as well as for personal practice. No issue is too big or too small to be filed and it is OK if you are not sure how to fix it yourself. If you know how to solve an issue, be sure to provide a detailed account of your research and show how to fix it. It is ok to file an issue about minor typos and very small changes, but do not make this the case for all of the issues that you file. You can also work on issues that you didn't create. -Make sure you have created at least one issue, resolved it, commented on an issue you didn't create and have a pull request with the fix merged before proceeding to the next step. +Make sure you have created at least one issue, resolved it, commented on an issue you didn't create and have a pull request with the fix merged. You may continue making Issues, Pull requests and Comments, or move on to the next step, while you are waiting for your pull request to be merged. The approval process for your Step 6 fix may take time, but it is OK to continue working. - Once you complete Step 6 you will have: * 2 pull requests made (one at step 3 and one at step 6) * 1 comment added (on an issue you didn't create) * 1 issue created +Please note that creating and working on Issues are not exactly bound by the "Step" you are in. Feel free to move on to other steps, and make more Issues and Pull Requests while you wait on OLE approval for your merge(s). + ## Step 7 - Nation Planet Follow the directions under the [Nation Planet tab](vi-nation.md). diff --git a/pages/vi/vi-github-issues.md b/pages/vi/vi-github-issues.md index d80d5645c..fc52f7a73 100644 --- a/pages/vi/vi-github-issues.md +++ b/pages/vi/vi-github-issues.md @@ -132,6 +132,8 @@ Additionally, creating a checklist will help others understand what you have don Some of these items are of course optional, but try to include as much useful information for others as possible in your checklists because nobody really wants to work on something that has already been completed by someone else. +NOTE: While you are waiting on two OLE team members to approve your Pull Requests, it is OK to keep creating more Issues and Pull Requests in the meantime. They will all count towards your final Issue/PR total, and PR approval can take time, so do not let a lengthy approval/fix process keep you from moving on in your "First Steps". + ## Delete the Branch * **Wait for the pull request merge!**