Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor the moodle proxy settings #10

Open
brendanheywood opened this issue May 1, 2020 · 0 comments · May be fixed by #11
Open

Honor the moodle proxy settings #10

brendanheywood opened this issue May 1, 2020 · 0 comments · May be fixed by #11

Comments

@brendanheywood
Copy link

$CFG->proxyhost is honored for free using the moodle curl library which is used here:

https://github.com/blackboard-open-source/moodle-mod_collaborate/blob/master/classes/rest/api.php#L199

But weird it isn't used in other places like:

https://github.com/blackboard-open-source/moodle-mod_collaborate/blob/master/classes/rest/api.php#L239

https://github.com/blackboard-open-source/moodle-mod_collaborate/blob/master/classes/soap/api.php#L164

Proposing to either conditionally pass through the moodle proxy settings or even better to swap to the moodle curl library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #10: Added proxy settings for Curl and soap requests nathancat/moodle-mod_collaborate
1 participant
@brendanheywood