Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DashboardDataModel is not properly updated when sql changes #18656

Open
aballiet opened this issue Nov 15, 2024 · 0 comments · May be fixed by #18657
Open

DashboardDataModel is not properly updated when sql changes #18656

aballiet opened this issue Nov 15, 2024 · 0 comments · May be fixed by #18657

Comments

@aballiet
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework?

Backend

Describe the bug
A clear and concise description of what the bug is.

When doing a patch to the server with

from_entity: Optional[DashboardDataModel] = self.metadata.get_by_name(
                entity=DashboardDataModel,
                fqn=f"{self.config.serviceName}.model.MY_MODEL_NAME",
)

to_entity: DashboardDataModel = deepcopy(from_entity)
to_entity.sql.root = "updated sql !"

self.metadata.patch(
     entity=DashboardDataModel,
     source=from_entity,
     destination=to_entity,
)

It does not update the entity in OMD. The response from patch contains same old sql value.

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

We expect the backend to update the entity in DB

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: 1.5.7
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@aballiet aballiet linked a pull request Nov 15, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant