Clarify bash (4?) requirement #675
Comments
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
sh (not bash) doesn't like it Refs #675 Signed-off-by: Brice Goglin <[email protected]>
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
Refs #675 Signed-off-by: Brice Goglin <[email protected]>
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
sh (not bash) doesn't like it Refs #675 Signed-off-by: Brice Goglin <[email protected]> (cherry picked from commit a3b64d5)
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
Refs #675 Signed-off-by: Brice Goglin <[email protected]> (cherry picked from commit 705a036)
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
sh (not bash) doesn't like it Refs #675 Signed-off-by: Brice Goglin <[email protected]> (cherry picked from commit a3b64d5)
bgoglin
added a commit
that referenced
this issue
Jul 29, 2024
Refs #675 Signed-off-by: Brice Goglin <[email protected]> (cherry picked from commit 705a036)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We implicitly require bash on Linux for some tests (eg several test-topology.sh and even bash 4 in test-bash-completion.sh). It's configure-checked but those tests are never disabled if bash is missing.
[update 2024/07/29]
As of 705a036 checkbashism only finds $RANDOM as a bashism in our scripts. It's only used when mktemp isn't available, things should still work unless multiple tests are parallelized.
Some of these tests still use sh are shebang, they should be fixed. Or if we remove $RANDOM, we should switch all them from bash to sh.
Bash 4 is very old, RHEL 6 and Debian 6 already had it, hence requiring (for completion only?) should be fine.
The text was updated successfully, but these errors were encountered: