-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile v4.1.7 with CUDA support broken #13005
Comments
I have seen the same issue. I guess that this was introduced in a697a27. A possible fix would probably be to fence lines 1821 to 1835 with |
You are correct. The following patch should fix the issue: diff --git a/opal/mca/common/cuda/common_cuda.c b/opal/mca/common/cuda/common_cuda.c
index b8ce5a7bea..ab5177fe7f 100644
--- a/opal/mca/common/cuda/common_cuda.c
+++ b/opal/mca/common/cuda/common_cuda.c
@@ -1818,6 +1818,7 @@ static int mca_common_cuda_check_mpool(CUdeviceptr dbuf, CUmemorytype *mem_type,
static int mca_common_cuda_get_primary_context(CUdevice dev_id, CUcontext *pctx)
{
+#if OPAL_CUDA_VMM_SUPPORT
CUresult result;
unsigned int flags;
int active;
@@ -1831,7 +1832,7 @@ static int mca_common_cuda_get_primary_context(CUdevice dev_id, CUcontext *pctx)
result = cuFunc.cuDevicePrimaryCtxRetain(pctx, dev_id);
return OPAL_SUCCESS;
}
-
+#endif /* OPAL_CUDA_VMM_SUPPORT */
return OPAL_ERROR;
}
|
Beauty, that worked, cheers! |
@bosilca I assume you'll submit a PR to fix this? 😄 |
bosilca
added a commit
to bosilca/ompi
that referenced
this issue
Jan 3, 2025
Fixes open-mpi#13005. Signed-off-by: George Bosilca <[email protected]>
bosilca
added a commit
to bosilca/ompi
that referenced
this issue
Jan 3, 2025
Fixes open-mpi#13005. bot:notacherrypick Signed-off-by: George Bosilca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for taking the time to submit an issue!
Background information
What version of Open MPI are you using? (e.g., v4.1.6, v5.0.1, git branch name and hash, etc.)
v4.1.7
Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)
From tarball openmpi-4.1.7.tar.bz2
If you are building/installing from a git clone, please copy-n-paste the output from
git submodule status
.Please describe the system on which you are running
Details of the problem
I am attempting to compile openmpi with CUDA v11.8 support, like this:
This results in the following error:
Please note that this does not happen with v4.1.6. Something has changed with openmpi-4.1.{6,7}/opal/mca/common/cuda/common_cuda.c.
Has anyone else seen this?
Thanks, David
The text was updated successfully, but these errors were encountered: