MPI_T: provide a stub implementation of events #13086
Open
+835
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
man pages will be added in a separate PR. Signed-off-by: Howard Pritchard <[email protected]>
|
@jsquyres per your request at last weeks meeting. |
|
related to #8057 |
bosilca
reviewed
Feb 12, 2025
jsquyres
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
In general, I think this looks like a great first step -- the API is there, and is conformant (even though it doesn't actually do anything). Extensions to make this API more functional would be welcome after this PR.
Any chance we could get some man pages and/or a mention somewhere in the docs about MPI_T events?
| @@ -1399,6 +1405,7 @@ if test $ac_cv_header_sys_synch_h = yes ; then | |||
| [Do not use outside of mpi.h. Define to 1 if you have the <sys/synch.h> header file.]) | |||
| fi | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit: spurious additional line.
|
i'll add man pages to this PR. |
Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
man pages will be added in a separate PR.