Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF and docx links on Nightly build don't work #7

Open
zgypa opened this issue Aug 6, 2024 · 0 comments
Open

PDF and docx links on Nightly build don't work #7

zgypa opened this issue Aug 6, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@zgypa
Copy link
Member

zgypa commented Aug 6, 2024

The nightly build doesn't tag properly, which means that the URL is incorrect. It comes through as something like https://github.com/open-ortho/dent-oip/releases/download/untagged-6ba25dfe4d74cbcaea5a/DENT-OIP.docx . This might have to do with the fact that the tagging is happening during the build process by Makefile, and the actions might not be aware of the new tag? Maybe simply a pull tags might do the trick, not sure.

Since the tagging on the main release is done by bumpversion, before the build process and before running the actions, the release works fine.

Or could it be because the draft releases are never tagged, just because they are drafts?

@zgypa zgypa added the bug Something isn't working label Aug 6, 2024
@zgypa zgypa added this to the v.1.0.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant