Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how dicom3tools dependency is dealt with. #7

Open
zgypa opened this issue Jan 22, 2023 · 0 comments
Open

Improve how dicom3tools dependency is dealt with. #7

zgypa opened this issue Jan 22, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zgypa
Copy link
Member

zgypa commented Jan 22, 2023

Currently, dicom3tools are used to test/verify the conformance of the produced image. There is a mention in README.md to use defaults.py. Could be better to use a .env schema? Or a local config scheme? Maybe default the location of the tools under modules/. The Makefile could automatically download the tool. I think the URL is pretty standard. For example:

https://www.dclunie.com/dicom3tools/workinprogress/winexe/dicom3tools_winexe_1.00.snapshot.20220618093127.zip
@zgypa zgypa added enhancement New feature or request help wanted Extra attention is needed labels Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zgypa