Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CPU Limits #607

Open
Archisman-Mridha opened this issue Nov 4, 2024 · 2 comments · May be fixed by #613
Open

Disable CPU Limits #607

Archisman-Mridha opened this issue Nov 4, 2024 · 2 comments · May be fixed by #613

Comments

@Archisman-Mridha
Copy link

Archisman-Mridha commented Nov 4, 2024 •
edited
Loading

In https://github.com/open-policy-agent/gatekeeper-library/blob/master/src/general/containerlimits/src.rego, instead of requiring the CPU limit to be specified for a container, we should rather disable the CPU Limit as a best practice.

REFER : https://home.robusta.dev/blog/stop-using-cpu-limits.

If approved, I can implement the solution :).
@JaydipGabani
Copy link
Contributor

This seems to be overlapping - open-policy-agent/gatekeeper#3723. I am fine with updating the policy in question. I would like to know opinion of others - @open-policy-agent/gatekeeper-library-maintainers

@ritazh
Copy link
Member

ritazh commented Dec 3, 2024

+1 on making the update. Since this is a breaking change, it would need to be a new major bump.

@fseldow fseldow linked a pull request Dec 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

containerlimits support to skip cpu limit validation fseldow/gatekeeper-library
3 participants
@ritazh @JaydipGabani @Archisman-Mridha