Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Controller Manager affinity can now be deleted. #2713

Closed

Conversation

kahirokunn
Copy link

What this PR does / why we need it:

You may wish to use topologySpreadConstraints to complete the process without using affinity.
In such cases, affinity can be removed.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@kahirokunn kahirokunn force-pushed the add-affinity-options branch 2 times, most recently from 41722b9 to 408cbfa Compare April 21, 2023 10:59
@sozercan
Copy link
Member

@kahirokunn thanks for the PR! Gatekeeper helm chart gets autogenerated. Please refer to Contributing to Helm Chart for modifying the Helm chart.

@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2023
@kahirokunn
Copy link
Author

keep

@stale stale bot removed the stale label Jul 9, 2023
@kahirokunn
Copy link
Author

keep

@ritazh
Copy link
Member

ritazh commented Aug 17, 2023

@kahirokunn thanks for the PR! Gatekeeper helm chart gets autogenerated. Please refer to Contributing to Helm Chart for modifying the Helm chart.

@kahirokunn Thanks for the PR! Please refer to Contributing to Helm Chart for steps on how to contribute changes to the Helm chart.

@stale
Copy link

stale bot commented Oct 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 16, 2023
@kahirokunn kahirokunn force-pushed the add-affinity-options branch from 408cbfa to 04ba3ca Compare October 16, 2023 07:04
@stale stale bot removed the stale label Oct 16, 2023
@kahirokunn
Copy link
Author

Is this correct?

@sozercan
Copy link
Member

@kahirokunn please run make manifests to generate manifests. you can refer to https://open-policy-agent.github.io/gatekeeper/website/docs/help/#contributing-to-helm-chart

@kahirokunn kahirokunn force-pushed the add-affinity-options branch 2 times, most recently from 14ba61d to a96c6ab Compare October 18, 2023 04:11
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7ff27dd) 52.51% compared to head (a96c6ab) 52.40%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2713      +/-   ##
==========================================
- Coverage   52.51%   52.40%   -0.12%     
==========================================
  Files         134      134              
  Lines       11952    11952              
==========================================
- Hits         6277     6263      -14     
- Misses       5185     5195      +10     
- Partials      490      494       +4     
Flag Coverage Δ
unittests 52.40% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kahirokunn kahirokunn force-pushed the add-affinity-options branch from a96c6ab to f766720 Compare October 18, 2023 04:50
@kahirokunn kahirokunn force-pushed the add-affinity-options branch from f766720 to 902f0e4 Compare October 18, 2023 04:57
@kahirokunn
Copy link
Author

@sozercan
Thx. I have read all of them. How about this time?

Copy link

stale bot commented Dec 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 17, 2023
@stale stale bot closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants