-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Controller Manager affinity can now be deleted. #2713
chore: Controller Manager affinity can now be deleted. #2713
Conversation
41722b9
to
408cbfa
Compare
@kahirokunn thanks for the PR! Gatekeeper helm chart gets autogenerated. Please refer to Contributing to Helm Chart for modifying the Helm chart. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
keep |
keep |
@kahirokunn Thanks for the PR! Please refer to Contributing to Helm Chart for steps on how to contribute changes to the Helm chart. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
408cbfa
to
04ba3ca
Compare
Is this correct? |
@kahirokunn please run |
14ba61d
to
a96c6ab
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2713 +/- ##
==========================================
- Coverage 52.51% 52.40% -0.12%
==========================================
Files 134 134
Lines 11952 11952
==========================================
- Hits 6277 6263 -14
- Misses 5185 5195 +10
- Partials 490 494 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a96c6ab
to
f766720
Compare
Signed-off-by: kahirokunn <[email protected]>
f766720
to
902f0e4
Compare
@sozercan |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
What this PR does / why we need it:
You may wish to use topologySpreadConstraints to complete the process without using affinity.
In such cases, affinity can be removed.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: