-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing nil pointer error when converting VAPB from v1beta1 to v1 #3754
fix: fixing nil pointer error when converting VAPB from v1beta1 to v1 #3754
Conversation
Signed-off-by: Jaydip Gabani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
- Coverage 54.49% 47.68% -6.82%
==========================================
Files 134 236 +102
Lines 12329 19924 +7595
==========================================
+ Hits 6719 9500 +2781
- Misses 5116 9529 +4413
- Partials 494 895 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…open-policy-agent#3754) Signed-off-by: Jaydip Gabani <[email protected]> (cherry picked from commit 14e6c8a)
…open-policy-agent#3754) Signed-off-by: Jaydip Gabani <[email protected]> (cherry picked from commit 14e6c8a)
…open-policy-agent#3754) Signed-off-by: Jaydip Gabani <[email protected]> (cherry picked from commit 14e6c8a)
… and updating crypto, net (#3754) (#3766) (#3781) Signed-off-by: Jaydip Gabani <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3753
Special notes for your reviewer: