Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export type SchemaArray = Undefined[]; #450

Open
bakon11 opened this issue Feb 7, 2023 · 1 comment · May be fixed by #458
Open

export type SchemaArray = Undefined[]; #450

bakon11 opened this issue Feb 7, 2023 · 1 comment · May be fixed by #458
Assignees

Comments

@bakon11
Copy link

bakon11 commented Feb 7, 2023

Describe the bug
A clear and concise description of what the bug is.
https://github.com/open-rpc/meta-schema/blame/78bb78fb9a5c3cd3f5117e5c681e43e9f31d7016/index.d.ts#L128

Since this changed from JSONSchema[] to Undefined on line 128 and few other lines:
134,
161,
188,
193,
197,
202,
209,
210,
211,
215,
236

Also exported as undefined the error Cannot find name 'Undefined'. shows up when building server side project.

I was able to fix the problem by changing the first one to:
export type SchemaArray = JSONSchema[];
and the rest as needed to JSONSchema

To Reproduce
Steps to reproduce the behavior:
Create a simple open-rpc project using latest generator, use typescript(only choice).
Create one simple method.
Go into server/typescript dir.
npm install
npm run build

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Debian 11
  • Node: 18.13.0
  • NPM: 9.4.1

image
image

Hope this helps.
Thanks.

@ValentinTrinque
Copy link

Same with golang version:

# github.com/open-rpc/meta-schema
../../../../go/pkg/mod/github.com/open-rpc/[email protected]/openrpc_document.go:168:20: undefined: Undefined

@BelfordZ BelfordZ self-assigned this Jul 6, 2023
wydengyre added a commit to wydengyre/meta-schema that referenced this issue Oct 20, 2023
Replace Undefined with JSONSchema.

Fixes open-rpc#450
Fixes open-rpc#457
wydengyre added a commit to wydengyre/meta-schema that referenced this issue Oct 20, 2023
Replace Undefined with JSONSchema.

Fixes open-rpc#450
Fixes open-rpc#457
wydengyre added a commit to wydengyre/meta-schema that referenced this issue Oct 20, 2023
Replace Undefined with JSONSchema.

Fixes open-rpc#450
Fixes open-rpc#457
@wydengyre wydengyre linked a pull request Oct 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants