-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot compile tests on macos #18
Comments
I have removed the dependency on
I'll investigate that in more detail the reason for each of them, but the last 6 must be failing because of |
Ok, I got all tests to compile and run. We just need 4 minor changes. I'll create a MR for it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tests in libvsync depend on several Linux specific features, making them non-portable. I believe that is unnecessary, since the library itself should work on other POSIX systems (and most of it should also work on non-POSIX systems).
The issues I’ve found are:
sys/sysinfo.h
sched_setaffinity
getrandom
inttypes.h
(although here I am unsure about the reason)If we could get rid of these dependencies, the test cases would be more portable and run on other POSIX systems like macOS.
The text was updated successfully, but these errors were encountered: