Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] replace all cpp class getters with accessors for consistency #346

Open
apaletta3 opened this issue Feb 14, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@apaletta3
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a mix of getters and accessors in OSTk cpp code, which is unnecessary and adds duplicate code.

Describe the solution you'd like
We could simply refactor all OSTk cpp getters to become accessors that return const references. This will reduce the amount of boilerplate code and also allow the user to choose what they want returned either a copy (const or non-const) or a const reference. But, for ease of use in Python we map the cpp accessors to python getters.

@apaletta3 apaletta3 added the enhancement New feature or request label Feb 14, 2024
@apaletta3 apaletta3 changed the title [feat] Issue title [refactor] replace all cpp class getters with accessors for consistency Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant