Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add convenience method to create a Position from a LLA #302

Closed
vishwa2710 opened this issue Dec 18, 2024 · 0 comments · Fixed by #305
Closed

[feat] add convenience method to create a Position from a LLA #302

vishwa2710 opened this issue Dec 18, 2024 · 0 comments · Fixed by #305
Assignees
Labels
enhancement New feature or request

Comments

@vishwa2710
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It would be nice to have a convenient static constructor in the Position class to construct it from a LLA.

Describe the solution you'd like

Position Position::fromLLA(const LLA& aLLA, const Shared<Celestial>& aCelestialPtr = nullptr)
{
    Shared<Celestial> centralBody
    if (aCelestialPtr == nullptr) || (!aCelestialPtr.isDefined())
    {
        Shared<Celestial> centralBody = Environment::getGlobalInstance()->accessCentralBody();
    }
...
}

Describe alternatives you've considered
Currently there exists methods in ostk.astrodynamics.utilities to convert position and lla but they are pure python methods.

@vishwa2710 vishwa2710 added the enhancement New feature or request label Dec 18, 2024
@vishwa2710 vishwa2710 self-assigned this Jan 4, 2025
@vishwa2710 vishwa2710 linked a pull request Jan 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant