Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/oidcauthextension] Fixes oidc extension skip client id check #36568

Open
zeck-ops opened this issue Nov 27, 2024 · 1 comment · May be fixed by #36569
Open

[extension/oidcauthextension] Fixes oidc extension skip client id check #36568

zeck-ops opened this issue Nov 27, 2024 · 1 comment · May be fixed by #36569
Assignees
Labels
enhancement New feature or request extension/oidcauth

Comments

@zeck-ops
Copy link

zeck-ops commented Nov 27, 2024

Component(s)

extension/oidcauthextension

Is your feature request related to a problem? Please describe.

My work is using AWS cognito, and we have a large number of client ids / audiences / app ids. Imagine a business with large business customers, that ended up having their own client ids.
For OTEL, we do not care what the audience is, we just want requests to be authenticated with the user pool.

Describe the solution you'd like

go-oidc has a SkipClientIdCheck property, that we would like to use through the collector.

Describe alternatives you've considered

The alternative with the collector at the moment seems like listening on a different port for each audience. The application would need to know which audience it was in, and which port to send to. This is not very feasible.

Or another alternative is not using the oidc extension and handling oidc authentication with like a reverse proxy or something before the collector.

@zeck-ops zeck-ops added enhancement New feature or request needs triage New item requiring triage labels Nov 27, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling jpkrohling removed the needs triage New item requiring triage label Nov 27, 2024
@zeck-ops zeck-ops changed the title [extension/oidcauthextension] oidc extension skip client id check [extension/oidcauthextension] Fixes oidc extension skip client id check Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension/oidcauth
Projects
None yet
2 participants