Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable merge queue on this repository #750

Closed
mx-psi opened this issue Nov 25, 2024 · 4 comments · Fixed by #755
Closed

Enable merge queue on this repository #750

mx-psi opened this issue Nov 25, 2024 · 4 comments · Fixed by #755
Assignees

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 25, 2024

We have wanted to enable a merge queue in opentelemetry-collector-contrib for some time now. To test it out first and remove any wrinkles, we want to roll this out on smaller repositories like opentelemetry-collector-releases first. To do that we would need to?:

  1. File a PR like [chore] Add build-and-test, build-and-test-windows, changelog and telemetrygen to merge group opentelemetry-collector-contrib#31162 on this repository
  2. File an issue on the community repo similar to this one: REQUEST: Repository maintenance on opentelemetry-collector-contrib community#1936
@ArthurSens
Copy link
Member

I'm looking at the docs and the example you provided now. For this repository, do I understand correctly that all workflows in this folder should be added to the merge queue? Or is there any workflow that we can ignore?

@mx-psi
Copy link
Member Author

mx-psi commented Nov 26, 2024

@ArthurSens I think for this repository anything with a trigger on pull requests or pushes to main should be in the merge group as well. So for example this one should not be added and this one should not be added either since they are triggered manually/with a tag push

@mx-psi
Copy link
Member Author

mx-psi commented Nov 26, 2024

Will close when open-telemetry/community/issues/2457 is done

@ArthurSens
Copy link
Member

And now this one should be good to close as well :)

@mx-psi mx-psi closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants