Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: update config dependency #11458

Conversation

codeboten
Copy link
Contributor

This brings in some breaking changes from the config package, mainly the headers on OTLP exporters are no longer a list of key value pairs but a list of name/value pairs.

This brings in some breaking changes from the config package, mainly the headers on OTLP exporters
are no longer a list of key value pairs but a list of name/value pairs.

Signed-off-by: Alex Boten <[email protected]>
@mjnowen
Copy link

mjnowen commented Oct 23, 2024

Related: #11478

@mjnowen
Copy link

mjnowen commented Oct 23, 2024

Please can we get this PR completed and merged as its causing me a broken CI pipeline/build at the moment.

@codeboten
Copy link
Contributor Author

@mjnowen working on it. this update requires a pretty substantial update in the collector's internal metrics configuration to preserve backwards compatibility. hoping to get to a good place for this update later this week

@mjnowen
Copy link

mjnowen commented Oct 24, 2024

Thanks @codeboten. FYI. I've been able to work around my issue temporarily with a replace pkg version for now, so this issue is important but I'm no longer broken.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 12, 2024
@codeboten
Copy link
Contributor Author

closing this in favour of #11611

@codeboten codeboten closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants