-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add text about unmaintained vendor components #11616
base: main
Are you sure you want to change the base?
[chore] add text about unmaintained vendor components #11616
Conversation
How do we know if a component is vendor-specific? Or maybe over time, do we want to no longer have any vendor-specific components? |
Good question. The git history/issues would have it, but right now it is probably relying more on the approvers/maintainers that were assigned as part of the rotation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11616 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 441 441
Lines 23922 23922
=======================================
Hits 21896 21896
Misses 1650 1650
Partials 376 376 ☔ View full report in Codecov by Sentry. |
Just to make is more interesting, is "datadogreceiver" vendor specific?
Can you tell me some "criterias" will you put to the history to determine this? |
@bogdandrutu I'd consider a component in contrib The datadogreceiver was not contributed under the above measures (and there are a few other components in contrib that touch vendor things but were not contributed by that vendor) so I would say it, and the others, are not vendor specific. I think to merge this change it would be appropriate to classify the components in contrib that are subject to the additional guidelines this PR proposes. I could do that by adding something to the metadata.yaml for the components or by building some list somewhere that indicates the vendor-specific components contrib houses. |
@@ -73,3 +73,8 @@ The component is planned to be removed in a future version and no further suppor | |||
### Unmaintained | |||
|
|||
A component identified as unmaintained does not have an active code owner. Such component may have never been assigned a code owner or a previously active code owner has not responded to requests for feedback within 6 weeks of being contacted. Issues and pull requests for unmaintained components will be labelled as such. After 6 months of being unmaintained, these components will be removed from official distribution. Components that are unmaintained are actively seeking contributors to become code owners. | |||
|
|||
Components that were accepted based on being vendor-specific components will be marked as unmaintained if | |||
it has no active code owners from the vendor even if there are other code owners listed. Other active code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has no active code owners from the vendor even if there are other code owners listed. Other active code | |
they have no active code owners from the vendor even if there are other code owners listed. Other active code |
@@ -73,3 +73,8 @@ The component is planned to be removed in a future version and no further suppor | |||
### Unmaintained | |||
|
|||
A component identified as unmaintained does not have an active code owner. Such component may have never been assigned a code owner or a previously active code owner has not responded to requests for feedback within 6 weeks of being contacted. Issues and pull requests for unmaintained components will be labelled as such. After 6 months of being unmaintained, these components will be removed from official distribution. Components that are unmaintained are actively seeking contributors to become code owners. | |||
|
|||
Components that were accepted based on being vendor-specific components will be marked as unmaintained if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say that we will attempt to reach out to the vendor to notify them of the component being marked as unmaintained?
@TylerHelmuth please resolve conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, conflicts need resolving though
Description
This PR adds language to our definition of
unmaintained
that allows vendor-specific components to become unmaintained if they lose an active code owner from the contributing vendor. This is necessary to prevent a vendor-specific component form being maintained only by the community instead of by the vendor. Since vendors had privileged access to getting components accepted in contrib they must be held to a higher standard for maintaining those components.