Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][docs/rfc] Add text regarding conversations #11738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore][docs/rfc] Add text regarding conversations #11738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/rfcs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,19 @@ We use a [Lazy Consensus](https://www.apache.org/foundation/glossary.html#LazyCo
1. *Quorum*: For an RFC to be mergeable, it needs to have at least **two approvals** from the
approvers set as well as approvals from any additional stakeholders.
2. *Waiting period*: Maintainers need to announce their intent to merge the RFC with a GitHub
comment. They will need to add a `rfc:final-comment-period` label to the PR and wait for at least
**4 business days** after making the announcement to merge the RFC.
comment. They will need to add a `rfc:final-comment-period` label to the PR, comment on the PR
and note the final comment period in the #otel-collector-dev CNCF Slack channel, and wait for at
least **4 business days** after making the announcement to merge the RFC.
mx-psi marked this conversation as resolved.
Show resolved Hide resolved
3. *Objections*: Objections should be communicated as a 'request changes' review. All objections
must be addressed before merging an RFC. If addressing an objection does not appear feasible, any
maintainer may call for a vote to be made on the objection (see below). This will be signified by
adding a `rfc:vote-needed` label to the PR. The voting result is binding and a maintainer can
drop any 'request changes' reviews based on the vote results or consensus.
4. *Modifications*: Non-trivial modifications to an RFC reset the waiting period. RFC authors must
re-request any approving, comment, or 'request changes' reviews if the RFC has been modified significantly.
5. *All conversations are resolved*: All Github conversations on the PR must be marked as resolved
before merging. The RFC author may resolve conversations at their discretion, but they must
explain in the conversation thread why they believe it is appropriate to do so.

### Voting

Expand Down
Loading