[SEMANTIC CONVENTIONS] Migration to weaver #3105
Open
+14,174
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
marcalff
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
==========================================
+ Coverage 87.12% 87.88% +0.76%
==========================================
Files 200 195 -5
Lines 6109 6137 +28
==========================================
+ Hits 5322 5393 +71
+ Misses 787 744 -43
|
16 tasks
|
Reviewers: Generated codeCode under api/include/opentelemetry/semconv is generated automatically. Make sure to review at least:
Weaver generationAll relevant code is under buildscripts/semantic-convention. Please review:
Example of usageVarious examples, tests, sdk files have been updated, and now use the new semconv generated code. |
|
@open-telemetry/weaver-maintainers @open-telemetry/cpp-maintainers Please review, and provide feedback. |
lquerel
approved these changes
Oct 31, 2024
buildscripts/semantic-convention/templates/registry/schema_url-h.j2
Outdated
Show resolved
Hide resolved
marcalff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3089
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes