Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db.redis.flags attribute implementation #2000

Open
tiagodaraujo opened this issue Aug 8, 2024 · 0 comments
Open

Remove db.redis.flags attribute implementation #2000

tiagodaraujo opened this issue Aug 8, 2024 · 0 comments
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis enhancement New feature or request

Comments

@tiagodaraujo
Copy link

Component

OpenTelemetry.Instrumentation.StackExchangeRedis

Is your feature request related to a problem?

The db.redis.flags attribute is being written to the OpenTelemetry.Instrumentation.StackExchangeRedis traces but this field is not in the semantic conventions : https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/redis.md.

This field should be removed from the implementation.

What is the expected behavior?

The db.redis.flags attribute should not exist in traces and metrics

Which alternative solutions or features have you considered?

Add the attribute to the semantic conventions: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/redis.md

Additional context

Also discussed here: #1982 (comment)

@tiagodaraujo tiagodaraujo added the enhancement New feature or request label Aug 8, 2024
@github-actions github-actions bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant