From 93038e21fafa122fa5136f98d5fe73242c45ff38 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Thu, 8 Feb 2024 17:36:51 -0800 Subject: [PATCH 1/2] Dispose loggerFactory in benchmark (#5330) --- test/Benchmarks/Logs/LogBenchmarks.cs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/Benchmarks/Logs/LogBenchmarks.cs b/test/Benchmarks/Logs/LogBenchmarks.cs index 73446e7f8b9..5c0f4ad28a5 100644 --- a/test/Benchmarks/Logs/LogBenchmarks.cs +++ b/test/Benchmarks/Logs/LogBenchmarks.cs @@ -72,6 +72,15 @@ public LogBenchmarks() this.loggerWithThreeProcessors = this.loggerFactoryWithThreeProcessor.CreateLogger(); } + [GlobalCleanup] + public void GlobalCleanup() + { + this.loggerFactoryWithNoListener.Dispose(); + this.loggerFactoryWithOneProcessor.Dispose(); + this.loggerFactoryWithTwoProcessor.Dispose(); + this.loggerFactoryWithThreeProcessor.Dispose(); + } + [Benchmark] public void NoListenerStringInterpolation() { From f214d27e9331426854836a266cb2d57c75333ed1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Fri, 9 Feb 2024 02:44:43 +0100 Subject: [PATCH 2/2] [Instrumentation.SqlClient] Improve changelog (#5327) --- src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md index 4bae2522a0c..ee69c187641 100644 --- a/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md @@ -12,6 +12,7 @@ `SqlClientTraceInstrumentationOptions`. ([#5285](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5285)) * **Breaking Change**: Stop emitting `db.statement_type` attribute. + This attribute was never a part of the [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/database/database-spans.md#call-level-attributes). ([#5301](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5301)) ## 1.6.0-beta.3