Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a clear exception handling strategy for extensibility components in SDK #1640

Open
utpilla opened this issue Dec 2, 2020 · 3 comments
Labels
documentation Documentation related enhancement New feature or request

Comments

@utpilla
Copy link
Contributor

utpilla commented Dec 2, 2020

We need to decide on whether we should let faulty third party extensibility components crash the SDK.

There are several extensibility components which can throw an exception anytime after initialization, and can cause app to fail in the middle of execution.

  • Sampler
  • Processor
  • Exporter (SimpleExportProcessor catches exceptions thrown by an exporter)
  • Instrumentation's Enrich
  • Instrumentations's Filter - (We do catch user exception here)
  • ExemplarFilter
  • ExemplarReservoir
@martinjt
Copy link
Member

I believe that we're solved this in that all those examples won't cause a failure.

I'd suggest, if there is more to this, that a ticket as a bug is created and if there is discussion to be had, we reopen this and discuss at the next SIG so we can get concrete actions.

@utpilla utpilla added the documentation Documentation related label Dec 12, 2023
@utpilla
Copy link
Contributor Author

utpilla commented Dec 12, 2023

I believe that we're solved this in that all those examples won't cause a failure.

A custom extension component can throw an exception. We need to formulate our stance on how we want to treat them. It would be good to discuss this in the SIG meeting.

@utpilla utpilla reopened this Dec 12, 2023
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
@cijothomas cijothomas removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants