Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanProcessor.OnStart, Sampler receives parent Context #1783

Open
cijothomas opened this issue Feb 3, 2021 · 2 comments
Open

SpanProcessor.OnStart, Sampler receives parent Context #1783

cijothomas opened this issue Feb 3, 2021 · 2 comments
Labels
question Further information is requested

Comments

@cijothomas
Copy link
Member

cijothomas commented Feb 3, 2021

Spec requires SpanProcesor.OnStart to receive the span and parentcontext (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onstart).
The .NET Implementation only provides Activity to OnStart on ActivityProcessor, and does not explicitly provide a parent Context.
However, it is possible to use Activity.Current.Parent.ActivityContext, and Baggage.Current to access parent ActivityContext, and Baggage.
Due to the difference in Activity semantics, and the way context is handled, it is not clear if we should mark "+" or "-" for the spec-compliance-matrix "SpanProcessor.OnStart receives parent Context".

Same issue for Sampler as well.

Marking "-" for these entries now.

@cijothomas cijothomas added the question Further information is requested label Feb 3, 2021
@cijothomas cijothomas changed the title SpanProcessor.OnStart receives parent Context SpanProcessor.OnStart, Sampler receives parent Context Feb 3, 2021
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 16, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2024
@cijothomas cijothomas reopened this Aug 24, 2024
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant