Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextSlot should not be "identified" by the string name #1810

Open
bogdandrutu opened this issue Feb 8, 2021 · 5 comments
Open

ContextSlot should not be "identified" by the string name #1810

bogdandrutu opened this issue Feb 8, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@bogdandrutu
Copy link
Member

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/context.md#create-a-key

@bogdandrutu bogdandrutu added the bug Something isn't working label Feb 8, 2021
@Oberon00
Copy link
Member

Oberon00 commented Feb 8, 2021

Or rather, the name should not be the key, but only additional debug info.

@martinjt
Copy link
Member

This looks to have been addressed now.

@cijothomas
Copy link
Member

cijothomas commented Dec 13, 2023

This looks to have been addressed now.

Don't think so. I see no PR linked linked to or referring this issue.

@Oberon00
Copy link
Member

Then please reopen to not lose it, if it has been adressed after all, you can re-close it with reference to the PR that fixed it

@cijothomas cijothomas reopened this Dec 19, 2023
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
@cijothomas cijothomas removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants