Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Update Exemplars before MetricPoint CompleteUpdate fires #5630

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Switches the order of UpdateExemplar & CompleteUpdate inside MetricPoint. According to @utpilla this is required for the delta MetricPoint reclaim feature to function correctly with exemplars enabled.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels May 17, 2024
@CodeBlanch CodeBlanch requested a review from a team May 17, 2024 20:46
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (6250307) to head (f5c1600).
Report is 230 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5630      +/-   ##
==========================================
+ Coverage   83.38%   85.71%   +2.33%     
==========================================
  Files         297      254      -43     
  Lines       12531    11036    -1495     
==========================================
- Hits        10449     9460     -989     
+ Misses       2082     1576     -506     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.46% <100.00%> (?)
unittests-Solution-Stable 85.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/MetricPoint.cs 94.24% <100.00%> (+25.76%) ⬆️

... and 113 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit a9c32c9 into open-telemetry:main May 17, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-exemplar-update-order branch May 17, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants