-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve exemplars tutorial #5636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5636 +/- ##
==========================================
+ Coverage 83.38% 85.77% +2.38%
==========================================
Files 297 254 -43
Lines 12531 11036 -1495
==========================================
- Hits 10449 9466 -983
+ Misses 2082 1570 -512
Flags with carried forward coverage won't be shown. Click here to find out more. |
Agree with all except removing docker requirement. Please keep it as optional, for those who prefer a single cmd over running multiple exes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Made it more self-contained (not depending on the ./examples which have lots of unrelated code).
Removed the docker requirement.
Switched to Jaeger (which is more aligned with the opentelemetry-demo project).