Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve exemplars tutorial #5636

Merged
merged 11 commits into from
May 21, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented May 21, 2024

Made it more self-contained (not depending on the ./examples which have lots of unrelated code).
Removed the docker requirement.
Switched to Jaeger (which is more aligned with the opentelemetry-demo project).

@reyang reyang requested a review from a team May 21, 2024 05:48
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (6250307) to head (9c43b72).
Report is 237 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5636      +/-   ##
==========================================
+ Coverage   83.38%   85.77%   +2.38%     
==========================================
  Files         297      254      -43     
  Lines       12531    11036    -1495     
==========================================
- Hits        10449     9466     -983     
+ Misses       2082     1570     -512     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.76% <ø> (?)
unittests-Solution-Stable 85.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 116 files with indirect coverage changes

@cijothomas
Copy link
Member

Made it more self-contained (not depending on the ./examples which have lots of unrelated code). Removed the docker requirement. Switched to Jaeger (which is more aligned with the opentelemetry-demo project).

Agree with all except removing docker requirement. Please keep it as optional, for those who prefer a single cmd over running multiple exes!

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch added the documentation Documentation related label May 21, 2024
@CodeBlanch CodeBlanch changed the title Improve exemplars tutorial [docs] Improve exemplars tutorial May 21, 2024
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 3cff6db into open-telemetry:main May 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants