Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ActivityExtensions.RecordException obsolete #5665

Closed
joegoldman2 opened this issue May 31, 2024 · 6 comments · Fixed by #5841
Closed

Mark ActivityExtensions.RecordException obsolete #5665

joegoldman2 opened this issue May 31, 2024 · 6 comments · Fixed by #5841
Assignees
Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package traces Tracing signal related
Milestone

Comments

@joegoldman2
Copy link
Contributor

Activity.AddException will be added in .NET 9 (dotnet/runtime#53641). Should ActivityExtensions.RecordException then be deprecated?

@martinjt
Copy link
Member

martinjt commented Jun 5, 2024

I'm not sure if we can do that anytime soon. It's probably valid, but a bit premature. since the adoption rate of .NET 9 will be slow (since it's not LTS), we'll need this for around 2 years at least.

If we develop a target for .NET 9 (I'm not sure if we will), it could be part of that.

We could look to update the docs, but even then it's going to be confusing for anyone not using .NET 9.

I think it should stay for a while, and it's not worth keeping an issue open for it until that happens.

@martinjt martinjt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@Kielek
Copy link
Contributor

Kielek commented Jun 5, 2024

@martinjt, typically OTel SDK bumps System.DiagnosticsDiagnosticSource to the latest version. If this happen now, there should be no blocker to redirect users to use new API.

@cijothomas
Copy link
Member

DS is out of band, so DS 9.0 can be used in any .NET versions, not just .NET 9. (OTel enforces that, as OTel always depend on the latest stable DS version.)

Deprecating ActivityExtensions.RecordException - this can be discussed during OTel 1.10 time, when it bumps to DS 9.0.

@Kielek Kielek added this to the 1.10.0 milestone Jun 5, 2024
@Kielek Kielek reopened this Jun 5, 2024
@Kielek
Copy link
Contributor

Kielek commented Jun 5, 2024

@cijothomas, putting to 1.10.0 to do not forget about this.

@martinjt
Copy link
Member

martinjt commented Jun 5, 2024

Totally my bad, .NET 9 threw me, completely forget it was in DS.

@CodeBlanch CodeBlanch added needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package traces Tracing signal related pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package labels Jun 11, 2024
@cijothomas
Copy link
Member

Move it out of 1.10 due to lack of owner. If anyone can lend hands, please reply here and we can re-add for 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package traces Tracing signal related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants