Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Replace the current trace implementation with the new one #6003

Merged

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes Part of #5730
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Replaced the current trace implementation with the new one. Deleted all existing implementations and renamed the new implementation to the existing names.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner November 27, 2024 21:15
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 27, 2024
@github-actions github-actions bot added the perf Performance related label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (7eeddf5) to head (3346ed8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6003      +/-   ##
==========================================
+ Coverage   85.03%   85.17%   +0.13%     
==========================================
  Files         276      272       -4     
  Lines       12693    12420     -273     
==========================================
- Hits        10794    10579     -215     
+ Misses       1899     1841      -58     
Flag Coverage Δ
unittests-Project-Experimental 85.14% <100.00%> (+0.11%) ⬆️
unittests-Project-Stable 84.89% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/ExportClient/ProtobufOtlpHttpExportClient.cs 82.35% <100.00%> (ø)
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 88.53% <100.00%> (+2.89%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 89.28% <100.00%> (+9.28%) ⬆️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 97.26% <100.00%> (+1.26%) ⬆️

... and 9 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title [otlp] Replace the current trace implementation with the new one. [otlp] Replace the current trace implementation with the new one Nov 27, 2024
@CodeBlanch CodeBlanch merged commit 84e6afb into open-telemetry:main Nov 27, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance related pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants