-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect user provided tracer name, version and schemaURL #844
Collect user provided tracer name, version and schemaURL #844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Tracer
name, version, and scope are the three identifying fields. By only using the tracer name here we are going to have collisions with the wrong tracer being used. The version and schema URL need to also be determined and used in the tracer resolution path.
I added the version. Regarding the schema, I noticed it was added recently (open-telemetry/opentelemetry-go#5426) to the traces map that the probe is reading, so currently it is not being read by the probe. We can add it once a new release of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@MrAlias I think this will break once the new version of |
Working on otel release here: open-telemetry/opentelemetry-go#5569 |
@RonFed Releases v1.28.0/v0.50.0/v0.4.0 was made yesterday. This should be unblocked. |
…ze. Including the schemaURL in newer versions.
773a781
to
4c0b974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Minor nits.
Looks like some tests need to be updated for the added schema URLs. |
Co-authored-by: Tyler Yahn <[email protected]>
When the
WithGlobal
InstrumentationOption is used, use the user provided tracer name.